Re: [PATCH 1/5] dt-bindings: display: mediatek: mdp-rsz: Add rules for MT8196

From: Conor Dooley
Date: Tue Feb 11 2025 - 12:54:35 EST


On Tue, Feb 11, 2025 at 10:52:50AM +0800, Sunny Shen wrote:
> Add MDP-RSZ hardware description for MediaTek MT8196 SoC
>
> Signed-off-by: Sunny Shen <sunny.shen@xxxxxxxxxxxx>
> ---
> .../display/mediatek/mediatek,mdp-rsz.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> new file mode 100644
> index 000000000000..6642b9aa651a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rsz.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/mediatek/mediatek,mdp-rsz.yaml#

Filename matching compatible please

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek display multimedia data path resizer
> +
> +maintainers:
> + - Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>
> + - Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> +
> +description: |
> + MediaTek display multimedia data path resizer, namely MDP-RSZ,
> + can do scaling up/down to the picture.
> +
> +properties:
> + compatible:
> + const: mediatek,mt8196-disp-mdp-rsz
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: MDP-RSZ Clock

This can just be "maxItems: 1"

> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + disp_mdp_rsz0: disp-mdp-rsz0@321a0000 {

And "disp-mdp-rsz0" isn't anything close to a generic node name.

> + compatible = "mediatek,mt8196-disp-mdp-rsz";
> + reg = <0 0x321a0000 0 0x1000>;
> + clocks = <&dispsys_config_clk 101>;

Surprised there are so few properties, no ports link or anything like
that?

> + };
> + };
> --
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature