Re: [PATCH v2 02/17] x86/smpboot: Fix INIT delay optimization for extended Intel Families

[Sohil Mehta]

On 2/11/2025 12:10 PM, Dave Hansen wrote:
> On 2/11/25 11:43, Sohil Mehta wrote:
>> Currently only Family 6 is considered as modern and avoids the 10 msec
>> INIT delay. The optimization doesn't extend to the upcoming Family 18/19
>> models.
> 
> This doesn't quite parse correctly to me.
> 
> Let's say it this way:
> 
> 	Some old crusty CPUs need an extra delay that slows down
> 	booting. See the comment above 'init_udelay' for details. Newer
> 	CPUs don't need the delay.
> 
> 	Right now, for Intel, Family 6 and only Family 6 skips the
> 	delay. That leaves out both the Family 15 (Pentium 4s) and brand
> 	new Family 18/19 models.
> 
> 	The omission of Family 15 (Pentium 4s) seems like an oversight
> 	and 18/19 do not need the delay.
> 
> 	Skip the delay on all Intel processors Family 6 and beyond.
> 
> Is there anything wrong there?

No, it is accurate.