Re: [PATCH v2 07/17] hwmon: Fix Intel Family-model checks to include extended Families

[Dave Hansen]

On 2/11/25 11:43, Sohil Mehta wrote:
> +	/*
> +	 * Return without adjustment if the Family isn't 6.
> +	 * The rest of the function assumes Family 6.
> +	 */
> +	if (c->x86 != 6)
> +		return tjmax;

Shouldn't we be converting this over to the vfm matches?

This is kinda icky:

> +	return family > 15 ||
> +	       (family == 6 &&
> +		model > 0xe &&
> +		model != 0x1c &&
> +		model != 0x26 &&
> +		model != 0x27 &&
> +		model != 0x35 &&
> +		model != 0x36);
>  }

I'm not sure how this escaped so far. Probably because it's not in arch/x86.