Re: [PATCH net-next] trace: tcp: Add tracepoint for tcp_cwnd_reduction()
From: Jakub Kicinski
Date: Tue Feb 11 2025 - 17:22:22 EST
On Fri, 07 Feb 2025 10:03:53 -0800 Breno Leitao wrote:
> +DECLARE_TRACE(tcp_cwnd_reduction_tp,
> + TP_PROTO(const struct sock *sk, int newly_acked_sacked,
> + int newly_lost, int flag),
> + TP_ARGS(sk, newly_acked_sacked, newly_lost, flag));
nit: I think that the ");" traditionally goes on a separate line?
regarding testing if the goal is the use in BPF perhaps you could
add a small sample/result to the commit message of using bpftrace
against it?
--
pw-bot: cr