Re: [PATCH] mm: pgtable: Unlock pml without branches when !start_pte
From: Andrew Morton
Date: Tue Feb 11 2025 - 18:51:55 EST
On Tue, 11 Feb 2025 14:49:47 +0800 I Hsin Cheng <richard120310@xxxxxxxxx> wrote:
> > if (ptl != pml)
> > +out_unlock:
> > spin_unlock(pml);
> > }
> > _
> >
> > but that's really ugly.
>
> I agree. Would you be so nice to suggest some test method for me so I
> can try to test how much benefit we can get from this?
>
> If the case happens frequently enough I think it might be worth it?
I expect this error patch is basically never taken - put a printk in
there and run some tests?