Re: [PATCH] perf tool_pmu: Add skip check in tool_pmu__event_to_str()
From: Namhyung Kim
Date: Tue Feb 11 2025 - 20:39:08 EST
On Fri, 07 Feb 2025 07:28:44 -0800, kan.liang@xxxxxxxxxxxxxxx wrote:
> Some topdown related metrics may fail on hybrid machines.
>
> $perf stat -M tma_frontend_bound
> Cannot resolve IDs for tma_frontend_bound:
> cpu_atom@TOPDOWN_FE_BOUND.ALL@ / (8 * cpu_atom@CPU_CLK_UNHALTED.CORE@)
>
> In the find_tool_events(), the tool_pmu__event_to_str() is used to
> compare the tool_events. It only checks the event name, no PMU or arch.
> So the tool_events[TOOL_PMU__EVENT_SLOTS] is set to true, because the
> p-core Topdown metrics has "slots" event.
> The tool_events is shared. So when parsing the e-core metrics, the
> "slots" is automatically added.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung