Re: [PATCH v1 1/4] x86/mce: Collect error message for severities below MCE_PANIC_SEVERITY

[Shuai Xue]

在 2025/2/12 00:51, Luck, Tony 写道:
> > +	char *tmp = *msg, cur_sev = MCE_NO_SEVERITY, sev;
>
> Should cur_sev and sev be of type "int" (since that's the type returned by mce_severity())?
>
> It doesn't matter today since the list of return value does fit into "char", but it is setting up
> to fail if that should ever change.
>
> -Tony

You are right, I previously only focused on the fact that the field 'sev' of
struct severity is an unsigned char.

Will fix it in next version.

Thanks.
Shuai