Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular
From: Herbert Xu
Date: Wed Feb 12 2025 - 00:29:32 EST
On Wed, Feb 12, 2025 at 05:09:36AM +0000, Eric Biggers wrote:
>
> Please name these like ARCH_HAS_CURVE25519 and CRYPTO_LIB_CURVE25519_ARCH to be
> consistent with the CRC library, the many other ARCH_HAS_* options, and
> CRYPTO_LIB_CURVE25519_GENERIC. Nothing uses names that contain "MAY_HAVE",
> which is ambiguous.
>
> FWIW, at some point the arch optimized crypto algorithms also need to just be
> enabled by default. The fact that they're not is a longstanding bug that is
> really harmful to users and needs to be fixed.
I'm simply responding to an lkp report. While your suggestions
may have merit, I don't have the time to pursue them.
Feel free to send patches if you wish.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt