Re: [PATCH 1/4] sounds: firewire: isight: changed strcpy to strscpy
From: Takashi Iwai
Date: Wed Feb 12 2025 - 02:23:56 EST
On Wed, 12 Feb 2025 02:23:46 +0100,
jack Livingood wrote:
>
> From: Jack Livingood <jacklivingood@xxxxxxxxxxx>
>
> fixed a spelling issue in the commit made previous
I already discarded your previous patch, so please give a full
description.
Takashi
>
> Signed-off-by: Jack Livingood <jacklivingood@xxxxxxxxxxx>
> ---
> sound/firewire/isight.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c
> index 806f82c9ceee..e9617fc0a532 100644
> --- a/sound/firewire/isight.c
> +++ b/sound/firewire/isight.c
> @@ -637,13 +637,13 @@ static int isight_probe(struct fw_unit *unit,
>
> card->private_free = isight_card_free;
>
> - strcpy(card->driver, "iSight");
> - strcpy(card->shortname, "Apple iSight");
> + strscpy(card->driver, "iSight");
> + strscpy(card->shortname, "Apple iSight");
> snprintf(card->longname, sizeof(card->longname),
> "Apple iSight (GUID %08x%08x) at %s, S%d",
> fw_dev->config_rom[3], fw_dev->config_rom[4],
> dev_name(&unit->device), 100 << fw_dev->max_speed);
> - strcpy(card->mixername, "iSight");
> + strscpy(card->mixername, "iSight");
>
> err = isight_create_pcm(isight);
> if (err < 0)
> --
> 2.48.1
>