Re: [PATCH] Staging: nvec: Fix pm_power_off reset condition in tegra_nvec_remove

From: Dan Carpenter
Date: Wed Feb 12 2025 - 02:33:26 EST


On Sun, Feb 09, 2025 at 09:16:48PM +0100, Dima Volkovsk wrote:
> In the current implementation of tegra_nvec_remove, the pm_power_off handler
> is set to NULL without checking if it is actually set to nvec_power_off. This
> change ensures that pm_power_off is only reset if it was previously set to
> nvec_power_off, preventing unintended side effects when removing the device.
>
> Signed-off-by: Dima Volkovsk <s0ldw3ll@xxxxxxxxx>

What everyone else said and also you forgot to add a Fixes tag.

regards,
dan carpenter