Re: [PATCH net 1/2] rtnetlink: Fix rtnl_net_cmp_locks() when DEBUG is off

From: Bastien Curutchet
Date: Wed Feb 12 2025 - 04:07:52 EST


On 2/12/25 9:45 AM, Kuniyuki Iwashima wrote:
From: "Bastien Curutchet (eBPF Foundation)" <bastien.curutchet@xxxxxxxxxxx>
Date: Wed, 12 Feb 2025 09:23:47 +0100
rtnl_net_cmp_locks() always returns -1 if CONFIG_DEBUG_NET_SMALL_RTNL is
disabled. However, if CONFIG_DEBUG_NET_SMALL_RTNL is enabled, it returns 0
when both inputs are equal. It is then used by rtnl_nets_add() to call
put_net() if the net to be added is already present in the struct
rtnl_nets. As a result, when rtnl_nets_add() is called on an already
present net, put_net() is called only if DEBUG is on.

If CONFIG_DEBUG_NET_SMALL_RTNL is disabled, every duplicate net is
added to rtnl_nets, so put_net() is expected to be called for each
in rtnl_nets_destroy().

I see, sorry for the irrelevant series then ...

Best regards,
Bastien