Re: (subset) [PATCH v3 00/15] gpiolib: add gpiod_multi_set_value_cansleep

From: Bartosz Golaszewski
Date: Wed Feb 12 2025 - 04:39:54 EST


From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>


On Mon, 10 Feb 2025 16:33:26 -0600, David Lechner wrote:
> This series was inspired by some minor annoyance I have experienced a
> few times in recent reviews.
>
> Calling gpiod_set_array_value_cansleep() can be quite verbose due to
> having so many parameters. In most cases, we already have a struct
> gpio_descs that contains the first 3 parameters so we end up with 3 (or
> often even 6) pointer indirections at each call site. Also, people have
> a tendency to want to hard-code the first argument instead of using
> struct gpio_descs.ndescs, often without checking that ndescs >= the
> hard-coded value.
>
> [...]

Applied, thanks!

[06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep
commit: eb2e9c308d2882d9d364af048eb3d8336d41c4bb

Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>