[PATCH v2] staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided
From: Michael Anckaert
Date: Wed Feb 12 2025 - 05:12:50 EST
Replace architecture-specific defines with CONFIG_X86 checks to improve
portability and adhere to kernel coding standards.
Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.
Changes made:
- Using CONFIG_X86 instead of i386 and x86.
Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Signed-off-by: Michael Anckaert <michael.anckaert@xxxxxxxxx>
---
Changes in v2:
- Moved the '} else {' into the ifdef to avoid the possibly empty
else branch
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 02860d3ec365..025dae3756aa 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -228,8 +228,8 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
reg = peek32(VGA_CONFIGURATION);
reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
poke32(VGA_CONFIGURATION, reg);
+#ifdef CONFIG_X86
} else {
-#if defined(__i386__) || defined(__x86_64__)
/* set graphic mode via IO method */
outb_p(0x88, 0x3d4);
outb_p(0x06, 0x3d5);
--
2.39.5