Re: [PATCH v1 1/1] virtio_console: Get rid of unneeded temporary variable

From: Amit Shah
Date: Wed Feb 12 2025 - 07:19:32 EST


On Mon, 2025-02-10 at 11:59 +0200, Andy Shevchenko wrote:
> When compiling a kernel with GCC using `make W=1` with
> CONFIG_WERROR=y
> (which is default nowadays), the build fails:
>
> drivers/char/virtio_console.c:1427:9: note: ‘snprintf’ output between
> 9 and 27 bytes into a destination of size 16
>
> Indeed, GCC can't see the limits of the variables that are in use.
> Fix this by using dev_name() of the newly created device that is
> luckily the same as the string used for the DebugFS node name.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/char/virtio_console.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Amit Shah <amit@xxxxxxxxxx>