Re: [PATCH V4 4/4] x86/tdx: Remove TDX specific idle routine

[Kirill A. Shutemov]

On Wed, Feb 12, 2025 at 12:07:47AM +0000, Vishal Annapurve wrote:
> With explicit dependency on CONFIG_PARAVIRT and TDX specific
> halt()/safe_halt() routines in place, default_idle() is safe to execute for
> TDX VMs. Remove TDX specific idle routine override which is now
> redundant.

I am not convinced that it is good idea.

It adds two needless flipping of IF in the hot path: first enabling
interrupts in tdx_safe_halt() and disabling it back in default_idle().

-- 
  Kiryl Shutsemau / Kirill A. Shutemov