Re: [PATCH net-next v4 3/3] net: phy: dp83822: Add support for changing the transmit amplitude voltage

From: Andrew Lunn
Date: Wed Feb 12 2025 - 08:18:57 EST


> + if (dp83822->tx_amplitude_100base_tx_index >= 0)
> + phy_modify_mmd(phydev, MDIO_MMD_VEND2, MII_DP83822_LDCTRL,
> + DP83822_100BASE_TX_LINE_DRIVER_SWING,
> + FIELD_PREP(DP83822_100BASE_TX_LINE_DRIVER_SWING,
> + dp83822->tx_amplitude_100base_tx_index));

So the driver leaves the value unchanged by default. Please make the
code and the binding match.

Andrew