Re: [PATCH v2] HID: corsair-void: Update power supply values with a unified work handler
From: Stuart
Date: Wed Feb 12 2025 - 08:30:30 EST
> No \n ^^ here.
Thanks, corrected that
> I would do an enum, but it's a matter of taste/preference.
I suppose that makes more sense since they're related, applied
> What is to skip a battery? Anyway, the comments here seem to be
> superfluous as the code is obvious™.
It was supposed to indicate doing nothing if there was a request to remove a
battery and another to add the battery, what would you suggest?
> Perhaps '&& drvdata->battery' instead of the nested 'if'?
Sure, what about corsair_void_add_battery()? It's got an equivalent
condition inside it, should I leave it there or move it to the
'add_battery && !remove_battery' for consistency?
Thanks for the review,
Stuart