Re: [PATCH v10 10/12] x86/mm: do targeted broadcast flushing from tlbbatch code

From: Brendan Jackman
Date: Wed Feb 12 2025 - 08:33:20 EST


On Tue, 11 Feb 2025 at 22:09, Rik van Riel <riel@xxxxxxxxxxx> wrote:
> @@ -798,6 +829,8 @@ void switch_mm_irqs_off(struct mm_struct *unused, struct mm_struct *next,
> if (IS_ENABLED(CONFIG_PROVE_LOCKING))
> WARN_ON_ONCE(!irqs_disabled());
>
> + tlbsync();
> +

Reminder to add comments or move this:

https://lore.kernel.org/linux-kernel/e8a156d4c8f5db07cf03b55fb81c75d523cac680.camel@xxxxxxxxxxx/

I actually sent another reply which is not yet visible in Lore
continuing to advocate for doing this in arch_start_context_switch() -
I won't die on that hill but I do think we need either that or the
commentary.