Re: [PATCH v2 2/2] unicode: kunit: change tests filename and path

[Thorsten Leemhuis]

On 12.02.25 07:45, Thorsten Leemhuis wrote:
> On 04.10.24 21:00, Gabriel Krisman Bertazi wrote:
>> Pedro Orlando <porlando@xxxxxxxxxx> writes:
> [...]
>> This breaks compilation for me.
>>
>> fs/unicode/tests/utf8_kunit.c:11:10: fatal error: utf8n.h: No such file or directory
>>    11 | #include "utf8n.h"
>>       |          ^~~~~~~~~
> 
> I encountered the same error when building -next using the Fedora
> rawhide config today. Given that this patch landed in -next today I
> suspect it might be due to this change, but I'm on the road and unable
> to verify that right now.

Did that now and this patch was indeed the culprit, as reverting
be6f498e7391 ("unicode: kunit: change tests filename and path") from
-next fixed the build error for me.

Ciao, Thorsten

> Log:
> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-rawhide-x86_64/08642966-next-next-all/builder-live.log.gz
>
>> After this patch that local header is now in the parent directory.
>>
>> I'm building with:
>>
>> CONFIG_UNICODE=m
>> CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST=m
>>
>>>  unicode-y := utf8-norm.o utf8-core.o
>>>  
>>> diff --git a/fs/unicode/.kunitconfig b/fs/unicode/tests/.kunitconfig
>>> similarity index 100%
>>> rename from fs/unicode/.kunitconfig
>>> rename to fs/unicode/tests/.kunitconfig
>>> diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/tests/utf8_kunit.c
>>> similarity index 100%
>>> rename from fs/unicode/utf8-selftest.c
>>> rename to fs/unicode/tests/utf8_kunit.c
>>
>