Re: (subset) [PATCH v2 0/3] gpiolib: refactor for_each_hwgpio()
From: Bartosz Golaszewski
Date: Wed Feb 12 2025 - 09:21:53 EST
From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
On Fri, 07 Feb 2025 17:07:33 +0200, Andy Shevchenko wrote:
> Some of the for_each_*() macros use the very similar piece of code
> that may be deduplicated (by introducing a new helper macro in patch 1).
> On top of that the implementation of the low-level for_each_hwgpio_in_range()
> looks too verbose. Try to simplify it (patches 2 and 3).
>
> Changelog v2:
> - added kernel-doc for a new helper (Bart)
> - added two more patches
>
> [...]
I applied patches 1 and 2. Please revisit 3/3 in order to not duplicate
the for_each_if() macro.
[1/3] gpiolib: Deduplicate some code in for_each_requested_gpio_in_range()
commit: 8893516000b247f91fa2cef34f2a77b609e661a4
[2/3] gpiolib: Simplify implementation of for_each_hwgpio_in_range()
commit: 767412f092fc6e04147305acd70f15770ece47ec
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>