Re: [PATCH net-next v2] af_unix: Fix undefined 'other' error

[Purva Yeshi]

On 11/02/25 06:02, Kuniyuki Iwashima wrote:
> From: Purva Yeshi <purvayeshi550@xxxxxxxxx>
> Date: Mon, 10 Feb 2025 13:20:06 +0530
> > Fix issue detected by smatch tool:
> > An "undefined 'other'" error occur in __releases() annotation.
> >
> > Fix an undefined 'other' error in unix_wait_for_peer() caused by
> > __releases(&unix_sk(other)->lock) being placed before 'other' is in
> > scope. Since AF_UNIX does not use Sparse annotations, remove it to fix
> > the issue.
> >
> > Eliminate the error without affecting functionality.
>
> The 5 lines of the 3 sentences above have trailing double spaces.
> You may want to configure your editor to highlight them.
>
> e.g. for emacs
>
> (setq-default show-trailing-whitespace t)

Thank you for pointing that out. I will ensure to check for such
issues before submitting future patches.

> > Signed-off-by: Purva Yeshi <purvayeshi550@xxxxxxxxx>
>
> Otherwise looks good.
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>

Thank you.

Best regards,
Purva Yeshi