Re: [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS

From: Mark Brown
Date: Wed Feb 12 2025 - 10:37:45 EST


On Wed, Feb 12, 2025 at 03:29:54PM +0000, Caleb Connolly wrote:

> I would suggest implementing a proper .is_enabled op to poll the status
> register for OTG_STATE_ENABLED and configuring

No, that would be buggy. Implement a get_status() operation if the
device can report status. is_enabled() should report what the driver
asked for.

Attachment: signature.asc
Description: PGP signature