Re: [PATCH 1/2] media: dt-bindings: Add dt bindings for m2m-deinterlace device

From: Krzysztof Kozlowski
Date: Wed Feb 12 2025 - 12:22:15 EST


On 12/02/2025 18:09, Matthew Majewski wrote:
> Create a new yaml schema file to describe the device tree bindings for
> the generic m2m-deinterlace driver.


Bindings are for hardware, not drivers, and usually not generic.

Please describe here exemplary devices.

>
> Signed-off-by: Matthew Majewski <mattwmajewski@xxxxxxxxx>
> ---
> .../bindings/media/m2m-deinterlace.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml b/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> new file mode 100644
> index 000000000000..3ac9c1e7be88
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/m2m-deinterlace.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: M2M Deinterlacer
> +
> +maintainers:
> + - Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> +
> +description: |
> + A generic memory2memory device for deinterlacing video
> + using dmaengine.

And what is this generic device supposed to do? What fits to generic device?

> +
> +properties:
> + compatible:
> + const: m2m-deinterlace
> +
> + dma-names:
> + items:
> + - const: rxtx
> +
> + dmas:
> + items:
> + - description: mem-to-mem capable DMA channel
> +
> +required:
> + - compatible
> + - dma-names
> + - dmas
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + m2m-deinterlace {
> + compatible = "m2m-deinterlace";
> + dma-names = "rxtx";
> + dmas = <&edma 20 0>;


This all looks rather like bindings for driver and not even quite
generic because looks quite simple. I guess media folks will provide
more input, but anyway it looks a bit not-DT-enough.

> + };


Best regards,
Krzysztof