Re: [PATCH] phy: stih407-usb: Use syscon_regmap_lookup_by_phandle_args
From: Krzysztof Kozlowski
Date: Wed Feb 12 2025 - 15:30:50 EST
On 11/01/2025 19:54, Krzysztof Kozlowski wrote:
> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
> syscon_regmap_lookup_by_phandle() combined with getting the syscon
> argument. Except simpler code this annotates within one line that given
> phandle has arguments, so grepping for code would be easier.
>
> There is also no real benefit in printing errors on missing syscon
> argument, because this is done just too late: runtime check on
> static/build-time data. Dtschema and Devicetree bindings offer the
> static/build-time check for this already.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> drivers/phy/st/phy-stih407-usb.c | 24 +++++++-----------------
> 1 file changed, 7 insertions(+), 17 deletions(-)
Vinod, was this patch lost?
There is review and patch should still apply. Let me know if you need
resend.
Best regards,
Krzysztof