Re: [PATCH 3/5] gpio: vsiapb: Add VeriSilicon APB support

[Linus Walleij]

Hi Nikolaos,

thanks for your patch!

This driver is really high quality, only nitpicks below.

With these addressed:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

On Wed, Feb 12, 2025 at 2:47 PM Nikolaos Pasaloukos
<nikolaos.pasaloukos@xxxxxxxxxx> wrote:

> VeriSilicon APB v0.2 is a custom GPIO design provided from VeriSilicon
> Microelectronics. It has 32 input/output ports which can be
> configured as edge or level triggered interrupts. It also provides
> a de-bounce feature.
>
> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@xxxxxxxxxx>
(...)
> +config GPIO_VSIAPB
> +       tristate "Verisilicon APB GPIO support"
> +       depends on OF_GPIO
> +       select GPIO_GENERIC
> +       select GPIOLIB_IRQCHIP
> +       select IRQ_DOMAIN_HIERARCHY

Are you really using the hierarchical domain?

Not in this driver, right? This is just regular chained IRQ.

> +       /* configure the gpio chip */
> +       gc = &chip->gc;
> +       gc->owner = THIS_MODULE;

I think the core sets up owner for you so you can drop this assignment?

Yours,
Linus Walleij