Re: [PATCH net 1/3] net: ethernet: ti: am65-cpsw: fix memleak in certain XDP cases

From: Jakub Kicinski
Date: Wed Feb 12 2025 - 23:14:45 EST


On Mon, 10 Feb 2025 16:52:15 +0200 Roger Quadros wrote:
> - /* Compute additional headroom to be reserved */
> - headroom = (xdp.data - xdp.data_hard_start) - skb_headroom(skb);
> - skb_reserve(skb, headroom);
> + headroom = xdp.data - xdp.data_hard_start;
> + }

I'm gonna do a minor touch up here and set the headroom in "else" hope
you don't mind. Easier to read the code if the init isnt all the way up
at definition. Also that way reverse xmas tree is maintained.