Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

[Cheng Jiang]

Hi Krzysztof,

On 2/11/2025 7:03 PM, Krzysztof Kozlowski wrote:
> On 11/02/2025 11:44, Cheng Jiang wrote:
>>  	};
>>  };
>>  
>> +&uart2 {
>> +	status = "okay";
>> +	bluetooth: bluetooth {
> 
> Why do you need the label?
> 
Yes, label is not needed. 
>> +		compatible = "qcom,wcn6855-bt";
>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>> +
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&bt_en_state>;
>> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>> +
>> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
>> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */
> 
> Only one space before '='.
> 
> I think this has multiple test failures.
> 
Ack, Will change in next version. 

> Best regards,
> Krzysztof