Re: [PATCH v2 0/5] Handheld gaming PC panel orientation quirks

[Thomas Zimmermann]

Hi

Am 12.02.25 um 20:59 schrieb John Edwards:
> Hello, Thomas and Hans.
>
> On Wed, Feb 12, 2025 at 5:14 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 12-Feb-25 12:11 PM, Thomas Zimmermann wrote:
> > > Hi
> > >
> > > Am 12.02.25 um 11:51 schrieb Hans de Goede:
> > > > Hi Thomas,
> > > >
> > > > On 11-Feb-25 2:55 PM, Thomas Zimmermann wrote:
> > > > > Hi
> > > > >
> > > > > Am 24.01.25 um 21:46 schrieb John Edwards:
> > > > > > Hello.
> > > > > >
> > > > > > I am submitting a small number of patches to add panel rotation quirks for
> > > > > > a few handheld gaming PCs.  These patches were created by the SteamFork
> > > > > > team and are in daily use by us and/or members of our community.
> > > > > >
> > > > > > The following devices are covered by these patches:
> > > > > > 1: AYANEO 2S
> > > > > > 2: AYANEO Flip DS, AYANEO Flip KB
> > > > > > 3: AYANEO Slide, Antec Core HS
> > > > > > 4: GPD Win 2 (with correct DMI strings)
> > > > > > 5: OneXPlayer Mini (Intel)
> > > > > >
> > > > > > Thank you for your consideration and for taking the time to review these
> > > > > > patches.
> > > > > Did you ever receive any response to this series? If not, then
> > > > >
> > > > > Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > > > I had the following remark for 3 new entries added in patches 2/5 + 3/5:
> > > >
> > > > "Since this '}' is closing the .matches initializer it should be indented 2 tabs"
> > > >
> > > > With that fixed, you can add my:
> > > >
> > > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > >
> > > > to the entire series.
> > > >
> > > > > for the series. Let me know if you need assistance for getting the patch files merged.
> > > > Normally I pickup/merge these panel orientation quirks, but I've been swamped
> > > > which is why these have just been sitting on the list.
> > > >
> > > > Thomas, I would appreciate it if you can merge the set into drm-misc-fixes, with
> > > > the 3 minor indentation issues fixed.
> > > Sure, no problem. I'll wait for John to provide an update. Otherwise, I'll fix it myself while merging the series.
> > Great thank you.
> >
> > Note in the review comments I said that we could likely fixup the indentation
> > issues while merging. If you prefer a new version from John that is fine too,
> > but we need to make clear to John what we want :)
> Thank you both for your comments and feedback.  I am more than happy to
> provide a v3 with the noted changes if requested.
>
> We have no other planned changes for this patch series, so if you wish to
> implement the changes while merging that is also acceptable to us.

Please send an update.

Best regards
Thomas

> Thank you both again.
>
> John Edwards
>
>
>
> > > > > > v2:
> > > > > > - Minor rewording of commit messages
> > > > > > - Include Tested-by tag for Paco Avelar in AYANEO Flip DS/KB patch
> > > > > > - Add OneXPlayer Mini (Intel) patch
> > > > > >
> > > > > > v1:
> > > > > > https://lore.kernel.org/dri-devel/20250116155049.39647-2-uejji@xxxxxxxxx/
> > > > > >
> > > > > > Andrew Wyatt (5):
> > > > > >      drm: panel-orientation-quirks: Add support for AYANEO 2S
> > > > > >      drm: panel-orientation-quirks: Add quirks for AYA NEO Flip DS and KB
> > > > > >      drm: panel-orientation-quirks: Add quirk for AYA NEO Slide
> > > > > >      drm: panel-orientation-quirks: Add new quirk for GPD Win 2
> > > > > >      drm: panel-orientation-quirks: Add quirk for OneXPlayer Mini (Intel)
> > > > > >
> > > > > >     .../gpu/drm/drm_panel_orientation_quirks.c    | 40 ++++++++++++++++++-
> > > > > >     1 file changed, 38 insertions(+), 2 deletions(-)

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)