Re: [PATCH v3 2/2] serial: tegra-utc: Add driver for Tegra UART Trace Controller (UTC)

[Jiri Slaby]

On 12. 02. 25, 16:09, Andy Shevchenko wrote:
> > +static bool tegra_utc_tx_chars(struct tegra_utc_port *tup)
> > +{
> > +	struct uart_port *port = &tup->port;
> > +	unsigned int pending;
> > +	u8 c;
> > +
> > +	pending = uart_port_tx(port, c,
> > +		     !(tegra_utc_tx_readl(tup, TEGRA_UTC_FIFO_STATUS) & TEGRA_UTC_FIFO_FULL),
> > +		     tegra_utc_tx_writel(tup, c, TEGRA_UTC_DATA));
>
> Make the last two to reside in temporary variables with self-explanatory names.

Not sure what you mean here? They are needed to be evaluated 
(read/written) in every loop.

--
js
suse labs