Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

[SkyLake Huang (黃啟澤)]

On Sun, 2025-01-19 at 18:12 +0100, Andrew Lunn wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> > +/* ch_addr = 0x1, node_addr = 0xf, data_addr = 0x1 */
> > +/* MrvlTrFix100Kp */
> > +#define MRVL_TR_FIX_100KP_MASK                       GENMASK(22,
> > 20)
> > +/* MrvlTrFix100Kf */
> > +#define MRVL_TR_FIX_100KF_MASK                       GENMASK(19,
> > 17)
> > +/* MrvlTrFix1000Kp */
> > +#define MRVL_TR_FIX_1000KP_MASK                      GENMASK(16,
> > 14)
> > +/* MrvlTrFix1000Kf */
> > +#define MRVL_TR_FIX_1000KF_MASK                      GENMASK(13,
> > 11)
> 
> What does the Mrvl prefix stand for?
> 
> This patch is pretty much impossible to review because it makes so
> many changes. Please split it up into lots of small simple changes.
> 
>     Andrew
> 
> ---
> pw-bot: cr
Those registers with Mrvl* prefix were originally designed for
connection with certain Marvell devices. It's our DSP parameters.

I'll split this change up in v2.

BRs,
Sky