Re: [PATCH net-next v3 3/3] arp: switch to dev_getbyhwaddr() in arp_req_set_public()
From: Kuniyuki Iwashima
Date: Thu Feb 13 2025 - 02:46:23 EST
From: Breno Leitao <leitao@xxxxxxxxxx>
Date: Wed, 12 Feb 2025 09:47:26 -0800
> The arp_req_set_public() function is called with the RTNL lock held,
> which provides enough synchronization protection. This makes the RCU
> variant of dev_getbyhwaddr() unnecessary. Switch to using the simpler
> dev_getbyhwaddr() function since we already have the required rtnl
> locking.
>
> This change helps maintain consistency in the networking code by using
> the appropriate helper function for the existing locking context.
>
> Suggested-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
Fixes: 941666c2e3e0 ("net: RCU conversion of dev_getbyhwaddr() and arp_ioctl()")
Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
I still think patch 2 & 3 should be posted to net separately.
Documentation/process/maintainer-netdev.rst
---8<---
the ``net`` tree is for fixes to existing code already in the
mainline tree from Linus
---8<---