Re: [PATCH 1/5] dt-bindings: hwmon: gpio-fan: Add optional regulator support

[Krzysztof Kozlowski]

On Mon, Feb 10, 2025 at 03:59:29PM +0100, Alexander Stein wrote:
> This adds an optional regulator support (e.g. switchable supply) to the

Add an...

> GPIO fan binding.
> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/hwmon/gpio-fan.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/gpio-fan.yaml b/Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
> index 7f30cfc873506..d5386990ab153 100644
> --- a/Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
> @@ -23,6 +23,9 @@ properties:
>    alarm-gpios:
>      maxItems: 1
>  
> +  fan-supply:
> +    description: Phandle to the regulator that provides power to the fan.

Look how fan-common.yaml writes it. It is really not necessary to say
that phandle is a phandle.

"Power supply for fan."

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof