Re: [PATCH v3] RDMA/irdma: switch to using the crc32c library

From: Leon Romanovsky
Date: Thu Feb 13 2025 - 07:43:00 EST



On Thu, 06 Feb 2025 20:08:16 -0800, Eric Biggers wrote:
> Now that the crc32c() library function directly takes advantage of
> architecture-specific optimizations, it is unnecessary to go through the
> crypto API. Just use crc32c(). This is much simpler, and it improves
> performance due to eliminating the crypto API overhead.
>
> Note that for crc32c the equivalent of crypto_shash_digest() is
> cpu_to_le32(~crc32c(~0, ...)), considering that crypto_shash_digest()
> had before and inversions as well as a cpu_to_le32() built-in. This
> means that this driver is using u32 for fixed-endian types; this patch
> does not try to fix that but rather just keep the exact same behavior.
>
> [...]

Applied, thanks!

[1/1] RDMA/irdma: switch to using the crc32c library
https://git.kernel.org/rdma/rdma/c/7fed5876df3d02

Best regards,
--
Leon Romanovsky <leon@xxxxxxxxxx>