Re: [PATCH] drivers: core: fix device leak in __fw_devlink_relax_cycles()

[Luca Ceresoli]

Hi Saravana,

On Thu, 13 Feb 2025 00:11:31 -0800
Saravana Kannan <saravanak@xxxxxxxxxx> wrote:

> On Wed, Feb 12, 2025 at 2:31 AM Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> wrote:
> >
> > Commit bac3b10b78e5 ("driver core: fw_devlink: Stop trying to optimize
> > cycle detection logic") introduced a new struct device *con_dev and a
> > get_dev_from_fwnode() call to get it, but without adding a corresponding
> > put_device().  
> 
> Thanks for debugging this and fixing it! Glad to see more people
> fixing fw_devlink code :)
> 
> > Link: https://lore.kernel.org/all/20241204124826.2e055091@booty/  
> Use the Closes: tag for this link. That tag is used to point to the
> bug report that this patch is fixing.

Good point! Sending v2 with Closes: tag and Cc: stable.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com