Re: [PATCH v2 06/10] i2c: kempld: Use i2c_10bit_addr_*_from_msg() helpers

[Wolfram Sang]

> @@ -132,10 +130,12 @@ static int kempld_i2c_process(struct kempld_i2c_data *i2c)
>  
>  	/* Second part of 10 bit addressing */
>  	if (i2c->state == STATE_ADDR10) {
> -		kempld_write8(pld, KEMPLD_I2C_DATA, i2c->msg->addr & 0xff);
> +		addr = i2c_10bit_addr_lo_from_msg(msg);
> +		i2c->state = STATE_START;

Any reason you moved this?

> +
> +		kempld_write8(pld, KEMPLD_I2C_DATA, addr);

Maybe we could skip using 'addr' here?

>  		kempld_write8(pld, KEMPLD_I2C_CMD, I2C_CMD_WRITE);
>  
> -		i2c->state = STATE_START;
>  		return 0;
>  	}

Attachment: signature.asc
Description: PGP signature