Re: [PATCH v11 00/12] AMD broadcast TLB invalidation

[Rik van Riel]

On Thu, 2025-02-13 at 19:31 +0100, Brendan Jackman wrote:
> On Thu, 13 Feb 2025 at 17:20, Rik van Riel <riel@xxxxxxxxxxx> wrote:
> > 
> > Add support for broadcast TLB invalidation using AMD's INVLPGB
> > instruction.
> 
> Oh - what if the user sets nopcid. We need to disable invlpgb in that
> case right?
> 
That's automatic, when !X86_FEATURE_PCID,
choose_new_asid() always returns 0, and
we never assign a global ASID to a task
on any CPU.

I suppose we could make "nopcid" a little
more efficient by short-circuiting the
code in consider_global_asid() as well,
but it should already work correctly.

Peter, do you prefer a v12, or should
additional small fixes and improvements
just be sent in follow-up patches at
this point?

-- 
All Rights Reversed.