Re: [PATCH v2] i2c: pxa: fix call balance of i2c->clk handling routines

[Andi Shyti]

Hi Vitalii,

On Wed, Feb 12, 2025 at 08:28:03PM +0300, Vitalii Mordan wrote:
> If the clock i2c->clk was not enabled in i2c_pxa_probe(), it should not be
> disabled in any path.
> 
> Found by Linux Verification Center (linuxtesting.org) with Klever.

here I added a blank line.

> Signed-off-by: Vitalii Mordan <mordan@xxxxxxxxx>

...

> -	clk_prepare_enable(i2c->clk);
> +	ret = clk_prepare_enable(i2c->clk);
> +	if (ret) {
> +		return dev_err_probe(&dev->dev, ret,
> +				     "failed to enable clock\n");
> +	}

I removed the brackets here that are not necessary.

Merged to i2c/i2c-host.

Thanks,
Andi

>  
>  	if (i2c->use_pio) {
>  		i2c->adap.algo = &i2c_pxa_pio_algorithm;
> -- 
> 2.25.1
>