Re: [PATCH V4 1/2] dmaengine: fsl-edma: cleanup chan after dma_async_device_unregister

[Peng Fan]

Hi Vinod,

Any comments?

Thanks,
Peng

On Fri, Dec 06, 2024 at 04:48:15PM +0800, Peng Fan (OSS) wrote:
>From: Peng Fan <peng.fan@xxxxxxx>
>
>There is kernel dump when do module test:
>sysfs: cannot create duplicate filename
>/devices/platform/soc@0/44000000.bus/44000000.dma-controller/dma/dma0chan0
> __dma_async_device_channel_register+0x128/0x19c
> dma_async_device_register+0x150/0x454
> fsl_edma_probe+0x6cc/0x8a0
> platform_probe+0x68/0xc8
>
>fsl_edma_cleanup_vchan will unlink vchan.chan.device_node, while
>dma_async_device_unregister  needs the link to do
>__dma_async_device_channel_unregister. So need move fsl_edma_cleanup_vchan
>after dma_async_device_unregister to make sure channel could be freed.
>
>So clean up chan after dma_async_device_unregister to address this.
>
>Fixes: 6f93b93b2a1b ("dmaengine: fsl-edma: kill the tasklets upon exit")
>Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
>---
>V4:
> None
>V3:
> Add R-b
>V2:
> Update commit log
>
> drivers/dma/fsl-edma-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
>index 60de1003193a..3966320c3d73 100644
>--- a/drivers/dma/fsl-edma-main.c
>+++ b/drivers/dma/fsl-edma-main.c
>@@ -668,9 +668,9 @@ static void fsl_edma_remove(struct platform_device *pdev)
> 	struct fsl_edma_engine *fsl_edma = platform_get_drvdata(pdev);
> 
> 	fsl_edma_irq_exit(pdev, fsl_edma);
>-	fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);
> 	of_dma_controller_free(np);
> 	dma_async_device_unregister(&fsl_edma->dma_dev);
>+	fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);
> 	fsl_disable_clocks(fsl_edma, fsl_edma->drvdata->dmamuxs);
> }
> 
>-- 
>2.37.1
>
>