Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

[SkyLake Huang (黃啟澤)]

On Thu, 2025-02-13 at 16:34 +0100, Andrew Lunn wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> > > > Those registers with Mrvl* prefix were originally designed for
> > > > connection with certain Marvell devices. It's our DSP
> > > > parameters.
> > > 
> > > Will this code work with real Marvell devices? Is this PHY
> > > actually
> > > licensed from Marvell?
> > 
> > > From what I understood the tuning of those parameters is required
> > to connect to a Marvell PHY link partner on the other end.
> 
> If so, the naming is bad. I assume you need the same settings for
> Microchip, Atheros, Broadcom, etc. These settings just tune the
> hardware to be standards conforming?
> 
>         Andrew
> 
This part is pretty old old old design. Some compatibility issues were
firstly found on Marvell link partners, so the registers are named
accordingly. And yes, now, those Kf/Kp settings will be used for
connection with other link partners. However, if I change the register
names, it violates our hardware register map application note. If this
does bother, I can add some comments before these macros like:

/* Mrvl* prefix only means that in the very beginning we tune the
 * parameters with Marvell link partners. These settings will be used
 * for all link partners now.
 */

BRs,
Sky