Re: [PATCH v5 1/8] scsi: ufs: core: Pass target_freq to clk_scale_notify() vop

From: Peter Wang (王信友)
Date: Fri Feb 14 2025 - 00:53:35 EST


On Thu, 2025-02-13 at 16:00 +0800, Ziqi Chen wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> From: Can Guo <quic_cang@xxxxxxxxxxx>
>
> Instead of only two frequencies, if OPP V2 is used, the UFS devfreq
> clock
> scaling may scale the clock among multiple frequencies, so just
> passing
> up/down to vop clk_scale_notify() is not enough to cover the
> intermediate
> clock freqs between the min and max freqs. Hence pass the target_freq
> ,
> which will be used in successive commits, to clk_scale_notify() to
> allow
> the vop to perform corresponding configurations with regard to the
> clock
> freqs.
>
> Signed-off-by: Can Guo <quic_cang@xxxxxxxxxxx>
> Co-developed-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
> Signed-off-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
> Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
> Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
>
> v1 -> v2:
> Modify commit message to make it more clear.
>
> v2 -> v3:
> Change 'vops' to 'vop' in commit message.
>
> v4 -> v5:
> keep the indentation consistent for clk_scale_notify() definition.
>
>

Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>