Re: [PATCH v5 4/8] scsi: ufs: qcom: Implement the freq_to_gear_speed() vop

From: Peter Wang (王信友)
Date: Fri Feb 14 2025 - 00:55:41 EST


On Thu, 2025-02-13 at 16:00 +0800, Ziqi Chen wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> From: Can Guo <quic_cang@xxxxxxxxxxx>
>
> Implement the freq_to_gear_speed() vop to map the unipro core clock
> frequency to the corresponding maximum supported gear speed.
>
> Signed-off-by: Can Guo <quic_cang@xxxxxxxxxxx>
> Co-developed-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
> Signed-off-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
> Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>
> Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
>
> v1 -> v2:
> Print out freq and gear info as debugging message.
>
> v2 -> v3:
> 1. Change "vops" to "vop" in commit message.
> 2. Removed variable 'ret' in function ufs_qcom_freq_to_gear_speed().
> 3. Removed parameters '*gear' and use gear value as return value for
>    funtion ufs_qcom_freq_to_gear_speed().
>
> v3 -> v4:
> Change the data type of 'gear' from 'int' to 'u32'.
> ---
>

Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>