Re: [PATCH] clk: renesas: rzv2h-cpg: Update error message

From: Geert Uytterhoeven
Date: Fri Feb 14 2025 - 05:03:28 EST


Hi Prabhakar,

Thanks for your patch!

On Tue, 11 Feb 2025 at 11:56, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Update the error message in `rzv2h_mod_clock_endisable()` to provide
> clearer debugging information. Instead of printing only the register
> address, include both the `GET_CLK_ON_OFFSET(reg)` offset and the

Indeed, printing the obfuscated virtual address is useless.

> corresponding `clk` name (`%pC`). This enhances readability and aids
> in debugging clock enable failures.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-clk for v6.15.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds