Re: [PATCH v1 0/5] gpio: regmap: Make use of 'ngpios' property

[Linus Walleij]

On Thu, Feb 13, 2025 at 8:56 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> It appears that regmap GPIO doesn't take into account 'ngpios' property
> and requires hard coded values or duplication of the parsing the same
> outside of GPIO library. This miniseries addresses that.
>
> For the record, I have checked all bgpio_init() users and haven't seen
> the suspicious code that this series might break, e.g., an equivalent of
> something like this:
>
> static int foo_probe(struct device *dev)
> {
>         struct gpio_chip *gc = devm_kzalloc(...);
>         struct fwnode_handle *fwnode = ...; // NOT dev_fwnode(dev)!
>
>         ...
>         gc->parent = dev;
>         gc->fwnode = fwnode;
>
>         ret = bgpio_init(gc, dev, ...);
>         ...
> }
>
> Reported-by: Mathieu Dubois-Briand <mathieu.dubois-briand@xxxxxxxxxxx>

Thanks for fixing this Andy!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij