Re: [PATCH] virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F_CTLS

From: Takashi Iwai
Date: Fri Feb 14 2025 - 07:01:27 EST


On Thu, 13 Feb 2025 17:18:25 +0100,
Stefano Garzarella wrote:
>
> As defined in the specification, the `controls` field in the configuration
> space is only valid/present if VIRTIO_SND_F_CTLS is negotiated.
>
> From https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html:
>
> 5.14.4 Device Configuration Layout
> ...
> controls
> (driver-read-only) indicates a total number of all available control
> elements if VIRTIO_SND_F_CTLS has been negotiated.
>
> Let's use the same style used in virtio_blk.h to clarify this and to avoid
> confusion as happened in QEMU (see link).
>
> Link: https://gitlab.com/qemu-project/qemu/-/issues/2805
> Signed-off-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

Applied now. Thanks.


Takashi