Re: [PATCH v6.13] fs/netfs/read_collect: fix crash due to uninitialized `prev` variable
From: David Howells
Date: Fri Feb 14 2025 - 08:07:15 EST
Max Kellermann <max.kellermann@xxxxxxxxx> wrote:
> prev = list_prev_entry(subreq, rreq_link);
> ...
> + if (subreq->start == prev->start + prev->len) {
> + prev = list_prev_entry(subreq, rreq_link);
Actually, that doubles the setting of prev redundantly. It shouldn't hurt,
but we might want to remove the inner one.
David