Re: [PATCH] net: freescale: ucc_geth: make ugeth_mac_ops be static

[Andrew Lunn]

On Fri, Feb 14, 2025 at 02:11:07PM +0800, xiaopeitux@xxxxxxxxxxx wrote:
> From: Pei Xiao <xiaopei01@xxxxxxxxxx>
> 
> sparse warning:
>     sparse: symbol 'ugeth_mac_ops' was not declared. Should it be
> static.
> 
> Add static to fix sparse warnings.

While you are touching it, can it also be made const?

struct phylink *phylink_create(struct phylink_config *,
			       const struct fwnode_handle *,
			       phy_interface_t,
			       const struct phylink_mac_ops *);

phylink_create() will accept a const struct *.

	Andrew