Re: [PATCH] bus: simple-pm-bus: fix forced runtime PM use

From: Johan Hovold
Date: Fri Feb 14 2025 - 08:32:22 EST


On Fri, Feb 14, 2025 at 02:16:14PM +0100, Geert Uytterhoeven wrote:
> On Fri, 14 Feb 2025 at 13:53, Johan Hovold <johan@xxxxxxxxxx> wrote:

> > I didn't add a CC stable tag since this currently works, but I still
> > consider it a bug to call these helpers unconditionally when not using
> > runtime PM.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > [ And during rc1 these callbacks were suddenly called and triggered a
> > NULL-pointer dereference as you know. [1] ]

> > [1] https://lore.kernel.org/lkml/Z6YcjFBWAVVVANf2@xxxxxxxxxxxxxxxxxxxx/
>
> Thanks, that was the context I needed to raise review priority ;)
>
> Perhaps Reported-by: and Closes:?

The glitch was only temporary this time and the immediate issue was
addressed by Rafael's partial revert in rc2:

https://lore.kernel.org/lkml/6137505.lOV4Wx5bFT@xxxxxxxxxxxxx/

(and which has these tags).

Johan