Re: [PATCH 6.12 000/422] 6.12.14-rc1 review

[Greg Kroah-Hartman]

On Fri, Feb 14, 2025 at 03:24:08PM +0530, Harshit Mogalapalli wrote:
> Hi Greg,
> 
> On 14/02/25 13:50, Greg Kroah-Hartman wrote:
> > On Fri, Feb 14, 2025 at 01:23:23PM +0530, Harshit Mogalapalli wrote:
> > > Hi,
> > > 
> > > 
> > > On 13/02/25 19:52, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.12.14 release.
> > > > There are 422 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > 
> > > I see these build failures:
> > > 
> > > fs/xfs/xfs_trans.c: In function '__xfs_trans_commit':
> > > fs/xfs/xfs_trans.c:843:40: error: macro "xfs_trans_apply_dquot_deltas"
> > > requires 2 arguments, but only 1 given
> > >    843 |         xfs_trans_apply_dquot_deltas(tp);
> > >        |                                        ^
> > > In file included from fs/xfs/xfs_trans.c:15:
> > > fs/xfs/xfs_quota.h:169:9: note: macro "xfs_trans_apply_dquot_deltas" defined
> > > here
> > >    169 | #define xfs_trans_apply_dquot_deltas(tp, a)
> > >        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > fs/xfs/xfs_trans.c:843:9: error: 'xfs_trans_apply_dquot_deltas' undeclared
> > > (first use in this function); did you mean 'xfs_trans_apply_sb_deltas'?
> > >    843 |         xfs_trans_apply_dquot_deltas(tp);
> > >        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >        |         xfs_trans_apply_sb_deltas
> > > fs/xfs/xfs_trans.c:843:9: note: each undeclared identifier is reported only
> > > once for each function it appears in
> > > make[4]: *** [scripts/Makefile.build:229: fs/xfs/xfs_trans.o] Error 1
> > > make[4]: *** Waiting for unfinished jobs....
> > > make[3]: *** [scripts/Makefile.build:478: fs/xfs] Error 2
> > > make[3]: *** Waiting for unfinished jobs....
> > > make[2]: *** [scripts/Makefile.build:478: fs] Error 2
> > > make[2]: *** Waiting for unfinished jobs....
> > > make[1]: *** [/builddir/build/BUILD/kernel-6.12.14/linux-6.12.14-master.20250214.el9.rc1/Makefile:1937:
> > > .] Error 2
> > > make: *** [Makefile:224: __sub-make] Error 2
> > > 
> > > 
> > > This commit: 91717e464c593 ("xfs: don't lose solo dquot update
> > > transactions") in the 6.12.14-rc1 is causing this.
> > 
> > Odd, I am guessing that you do not have CONFIG_XFS_QUOTA enabled?
> > 
> 
> I do have that enabled.
> 
> CONFIG_XFS_QUOTA=y

Odd, that didn't trip in my test builds :(

Anyway, now dropped, thanks!

greg k-h