Re: [PATCH v1 1/2] nouveau/svm: fix missing folio unlock + put after make_device_exclusive_range()

From: Danilo Krummrich
Date: Fri Feb 14 2025 - 10:19:07 EST


On Fri, Jan 24, 2025 at 07:15:23PM +0100, David Hildenbrand wrote:
> In case we have to retry the loop, we are missing to unlock+put the
> folio. In that case, we will keep failing make_device_exclusive_range()
> because we cannot grab the folio lock, and even return from the function
> with the folio locked and referenced, effectively never succeeding the
> make_device_exclusive_range().
>
> While at it, convert the other unlock+put to use a folio as well.
>
> This was found by code inspection.
>
> Fixes: 8f187163eb89 ("nouveau/svm: implement atomic SVM access")
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>

Applied to drm-misc-fixes, thanks!