Re: [PATCH v2 09/17] KVM: TDX: Handle SMI request as !CONFIG_KVM_SMM

From: Edgecombe, Rick P
Date: Fri Feb 14 2025 - 12:16:25 EST


On Wed, 2025-02-12 at 13:51 +0800, Binbin Wu wrote:
> > Rather than have a metric ton of stubs for all of the TDX variants, simply
> > omit
> > the wrappers when CONFIG_KVM_INTEL_TDX=n.  Quite nearly all of vmx/main.c
> > can go
> > under a single #ifdef.  That eliminates all the silly trampolines in the
> > generated
> > code, and almost all of the stubs.
> Thanks for the suggestion!
>
> Since the changes will be across multiple sections of TDX KVM support,
> instead of modifying them individually, are you OK if we do it in a separate
> cleanup patch?

Paolo, since this would have small changes across the whole series, we would
have to figure out how get it into the "queued" kvm-coco-queue patches. I think
the two reasonable options would be to just have you do the change in kvm-coco-
queue, and we would merge our later other changes back into the resulting
branch. Or we could just do the macro as a cleanup patch after the base series.

We'll go with the second option unless we hear otherwise.